Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page): added delete-item hover color #4299

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

RajeevDash007
Copy link
Contributor

fixed: #4298
Screenshot (101)

@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 3:42am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 3:42am

@hwangdev97
Copy link
Member

I saw:
shot-2023-08-23-11 28 40@2x

but our design:

I think an icon needs to be added here

shot-2023-08-23-11 30 12@2x

cc @zanwei

@RajeevDash007
Copy link
Contributor Author

RajeevDash007 commented Aug 23, 2023

I have added the delete icon

@Svaney-ssman
Copy link

I have added the delete icon

The delete icon and the edit icon, check detail here

@Svaney-ssman
Copy link

Svaney-ssman commented Aug 23, 2023

default status, hover status are also missing, don't forget the blue shadow in the active status
check design

@Svaney-ssman Svaney-ssman self-requested a review August 23, 2023 04:02
@zanwei
Copy link
Member

zanwei commented Aug 23, 2023

default status, hover status are also missing, don't forget the blue shadow in the active status
check design

image

@zzj3720
Copy link
Member

zzj3720 commented Aug 23, 2023

default status, hover status are also missing, don't forget the blue shadow in the active status check design

image

The menu UI refactoring is not yet complete, I think we just need to simply fix the UI of delete for now, and I'll finish the menu UI refactoring in the next iteration.

@doodlewind
Copy link
Member

The menu UI refactoring is not yet complete, I think we just need to simply fix the UI of delete for now, and I'll finish the menu UI refactoring in the next iteration.

Yes, @xell I think we need to distinguish the type:feat and type:bug for UI issues. Having the standalone fixes landed atomically should match our policy.

@RajeevDash007
Copy link
Contributor Author

default status, hover status are also missing, don't forget the blue shadow in the active status check design

image

The menu UI refactoring is not yet complete, I think we just need to simply fix the UI of delete for now, and I'll finish the menu UI refactoring in the next iteration.

I guess, I have done that, Kindly check it and if you need any changes then let me know

Copy link

@Svaney-ssman Svaney-ssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @zzj3720 said approve this issue firstly

@zzj3720 zzj3720 merged commit ee14ecd into toeverything:master Aug 23, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Delete view is not set to red (css-variable) while hovering
6 participants