free string returned by mpv

tsl0922 · Feb 7, 2023 · 11043cb · 11043cb
1 parent a3f55ec
commit 11043cb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/source/views/context_menu.cpp b/source/views/context_menu.cpp
@@ -246,7 +246,7 @@ void ContextMenu::drawAudioDeviceList() {
 
 void ContextMenu::drawTracklist(const char *type, const char *prop) {
   auto items = mpv->trackList();
-  auto value = mpv->property(prop);
+  char *value = mpv->property(prop);
   if (ImGui::BeginMenuEx("Tracks", ICON_FA_LIST)) {
     if (ImGui::MenuItem("Disable", nullptr, strcmp(value, "no") == 0))
       mpv->commandv("cycle-values", prop, "no", "auto", nullptr);
@@ -259,6 +259,7 @@ void ContextMenu::drawTracklist(const char *type, const char *prop) {
     }
     ImGui::EndMenu();
   }
+  mpv_free(value);
 }
 
 void ContextMenu::drawChapterlist(std::vector<Mpv::ChapterItem> items) {

diff --git a/source/views/quickview.cpp b/source/views/quickview.cpp
@@ -86,9 +86,10 @@ bool Quickview::toggleButton(bool toggle, const char *tooltip) {
 void Quickview::drawTracks(const char *type, const char *prop) {
   ImGui::Text("Tracks");
   alignRight(ICON_FA_TOGGLE_ON);
-  const char *state = mpv->property(prop);
+  char *state = mpv->property(prop);
   if (toggleButton(state && !iequals(state, "no"), "Toggle Tracks"))
     mpv->commandv("cycle-values", prop, "no", "auto", nullptr);
+  mpv_free(state);
   if (ImGui::BeginListBox("##tracks", ImVec2(-FLT_MIN, 3 * ImGui::GetTextLineHeightWithSpacing()))) {
     auto items = mpv->trackList();
     if (items.empty()) ImGui::TextDisabled("<Empty>");