Fix/batch backfill v18

[DavidWeiss2]

Change Summary

The current batch mechanism is failing on Firestore big collections with a function crash.
This PR fixing this issue.

Also on this PR -
Better comments for failing batch (the current one get trimmed when multiple errors)

but for v18

PR Checklist

• I have read and signed the Contributor License Agreement.

[DavidWeiss2]

Saw the conflicts, fixing them.

[DavidWeiss2]

@jasonbosco Conflict resolved

[jasonbosco]

Looks like tests are failing

[tharropoulos]

Looks like tests are failing

In 30105bc , there was a change introduced on line 53, regarding the currentDocumentsBatch variable

const currentDocumentsBatch = thisBatch.docs.map((doc) => utils.typesenseDocumentFromSnapshot(doc));

This implementation resulted in currentDocumentsBatch being an array of pending promises, as typesenseDocumentFromSnapshot is an asynchronous function (Although only because of the dynamic import of flat).

So, in b8d9207, changing this line to

const currentDocumentsBatch = await Promise.all(thisBatch.docs.map(async (doc) => {
  return await utils.typesenseDocumentFromSnapshot(doc);
}));

takes care of the issue, resolving to the corresponding document schema that the import endpoint expects.

[tharropoulos]

Rebased master into the branch, can now target master.

[DavidWeiss2]

What needed to fix in this PR in order to merge it?

[tharropoulos]

What needed to fix in this PR in order to merge it?

Tests were failing, I've posted a comment above referencing what went wrong (returning a promise instead of unpacking it)

[DavidWeiss2]

What needed to fix in this PR in order to merge it?

Tests were failing, I've posted a comment above referencing what went wrong (returning a promise instead of unpacking it)

So now this is just waiting for Jason approval?