Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed manual accounting of field's count #12842

Open
wants to merge 58 commits into
base: master
Choose a base branch
from

Conversation

igeni
Copy link

@igeni igeni commented Mar 23, 2024

Removed manual accounting of field's count and added option to change text justification

I have read the CLA Document and I hereby sign the CLA

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Refactoring log messages for simplicity and consistency 🛠️✨

📊 Key Changes

  • Simplified the logging format in training and validation scripts.
  • Changed log string concatenation to a more concise and dynamic generation method using list comprehensions.
  • Removed verbose, repetitive code blocks for logging, replaced with cleaner, one-line statements.

🎯 Purpose & Impact

  • Purpose: To make the codebase easier to maintain and understand by streamlining the generation of log messages. This change supports cleaner code practices and reduces clutter.
  • Impact: Users will experience no direct impact on functionality, but developers working on or with YOLOv5 will find the code more accessible and easier to modify or debug. The change also ensures that log messages maintain a consistent format, improving readability for users monitoring training or validation processes.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @igeni, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with ultralytics/yolov5 master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify all YOLOv5 Continuous Integration (CI) checks are passing.
  • ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

@glenn-jocher
Copy link
Member

@igeni thank you for the PR and for your contributions towards making YOLOv5 better! 🌟 Your effort in refactoring the logging system to improve code readability and maintainability is indeed appreciated.

Streamlining log message generation is crucial for both developers and users. It not only makes the codebase cleaner but also enhances the overall debugging and monitoring experience. Your focus on simplicity and consistency aligns well with our goals for YOLOv5.

The changes outlined, from simplifying log formats to employing dynamic generation methods for strings, are valuable. Ensuring log messages follow a consistent format is key to a good user experience during model training and validation.

We'll review the details and impact of your proposed changes closely. Your contribution helps us move towards a more efficient and user-friendly YOLOv5.

Thanks again for your hard work and for being part of the YOLOv5 community! 🚀

Copy link
Contributor

github-actions bot commented Apr 9, 2024

All Contributors have signed the CLA. ✅
Posted by the CLA Assistant Lite bot.

@igeni
Copy link
Author

igeni commented Apr 10, 2024

I have read the CLA Document and I sign the CLA

@igeni
Copy link
Author

igeni commented Apr 18, 2024

@glenn-jocher At least 1 approving review is required :)

@glenn-jocher
Copy link
Member

@igeni Thanks for the reminder! We'll ensure your PR gets reviewed by the team 🚀. Keep an eye out for any comments or requests for changes from our reviewers. We appreciate your patience and contribution!

UltralyticsAssistant and others added 30 commits June 20, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants