Add Config-Switch "PASSIVE_BUZZER" #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sive buzzer/piezo
|
Did you make modifications on platformio.ini? |
|
Hi Bruno,
when not setting this config-switch in platform.ini BrewUno works as it was initially set up. When setting it, it creates the tone() for a passive buzzer/piezo.
So there is no need to change the platform.ini for that.
But I could add it there and comment in out (default behaviour). How is the project handling other optional “ifdef” in platform.ini?
Kind regards
|
|
can you please complete this PR or is there ay todo from my site? |
|
does this PR still make sense? |
|
yes it makes sense in my opinion. There are electrical active or passive buzzer which you can buy. Then you could easily build your device with both types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Config-Switch "PASSIVE_BUZZER" for changing between active or passive buzzer/piezo