Fix date time format in ICU4J, ICU4C, ICU4X #297
Conversation
|
"2024-03-07T00:00:01.00Z" is the instant that you want to format. You want to format the instant in a particular time zone and calendar. You pass those values in the options bag. You should not need to put them into the IXDTF string. If you do, there is a conflict. |
sven-oly
changed the title
sven-oly
changed the title
|
ICU4X has multiple fixes in the latest commit, fixing about 1/2 of all the test failures.
There are still test failures in formatting, including issues with using 12 vs. 24 hour time based on the locale. Also, there are details of formatting the GMT offsets, e.g., ICU4X gives "GMT +09:00" vs. "GMT+9" as expected. |
|
PTAL |
...main/java/org/unicode/conformance/testtype/datetimeformatter/DateTimeFormatterDateStyle.java
Outdated
Show resolved
Hide resolved
...main/java/org/unicode/conformance/testtype/datetimeformatter/DateTimeFormatterDateStyle.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/unicode/conformance/testtype/datetimeformatter/DateTimeFormatterTester.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/unicode/conformance/testtype/datetimeformatter/DateTimeFormatterTester.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/unicode/conformance/testtype/datetimeformatter/DateTimeFormatterTester.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/unicode/conformance/testtype/datetimeformatter/DateTimeFormatterTester.java
Outdated
Show resolved
Hide resolved
...main/java/org/unicode/conformance/testtype/datetimeformatter/DateTimeFormatterTimeStyle.java
Outdated
Show resolved
Hide resolved
| let temporal_date = temporal_dates[date_index]; | ||
| temporal_date['timeZone'] = timezone; | ||
| let zdt = Temporal.ZonedDateTime.from(temporal_date); | ||
| let temporal_instant = zdt.toInstant(); |
There was a problem hiding this comment.
Move these three lines to between 444 and 445, which is closer to where they're first used.
There was a problem hiding this comment.
This is the only comment that hasn't been addressed.
|
PTAL! |
This updates the timezone generator to output Instant data of the form in UTC:
"2024-03-07T00:00:01.00Z"
This instant is used to create the expected result with a given calendar and timezone.
The Java code parses this instant, then applies the options for timezone and calendar to create a formatted output.
Java: Also update to handle date style and time style options better.
This removes "und" from the locales generated in test data because that locale doesn't work the same was across different platforms.
closing #266 #267