-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: response panel split horizontal #2194
base: main
Are you sure you want to change the base?
feature: response panel split horizontal #2194
Conversation
Hey small thing, instead of opening a new PR every time you squash your commits, you can just rebase your branch and then force push. This way you don't have to open & close your PR's. |
Ok sorry about that, I will do like you suggest next times |
3967588
to
3a08877
Compare
Sorry for making more changes to my PR recently, but I am now happy with my changes, I am confident it works because I went through all screens to verify the display. |
looking forward to seeing this one merged |
Same!! |
Hi @sanjai0py, would you be able by any chance to assign the PR to someone for review ? |
Hi @Its-treason Would you have the chance to review this PR, currently it's not assigned to anyone |
I can review your PR in the next few days. But your PR is quite big, so it will take some time to review. But before I start reviewing this, I would like for @helloanoop to confirm that: We want this, and it gets merged soon after reviewing. |
@busy-panda This is something that we definetely want to get merged. One of the concerns I have merging a large PR like this is that it would also need extensive testing before we ship the build as we do not want to break the interface for the current vertical split (like the code editor heights) Also, there is a large number of other PR's that rank higher in priority. |
5d5bcbd
to
099d287
Compare
# Conflicts: # packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js
099d287
to
de7f305
Compare
Hi @helloanoop I fixed the conflicts and retested. |
I second this being merged in, this is a great feature. |
Thanks for taking the time to work on this @end3rbyte ! The PR is quite huge, and the code has also undergone significant changes. I feel this functionality is better implemented by someone here internally at Bruno Core Team. |
# Conflicts: # packages/bruno-app/src/components/CodeEditor/index.js # packages/bruno-app/src/components/CollectionSettings/Script/index.js # packages/bruno-app/src/components/Documentation/StyledWrapper.js # packages/bruno-app/src/components/Documentation/index.js # packages/bruno-app/src/components/RequestPane/GraphQLRequestPane/index.js # packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js # packages/bruno-app/src/components/RequestPane/QueryEditor/StyledWrapper.js # packages/bruno-app/src/components/RequestPane/RequestBody/StyledWrapper.js # packages/bruno-app/src/components/RequestPane/Script/index.js # packages/bruno-app/src/components/RequestTabPanel/index.js # packages/bruno-app/src/components/ResponsePane/Overlay/index.js # packages/bruno-app/src/components/VariablesEditor/index.js
…yParams This partially reverts commit 2191550.
Hi @helloanoop horizontal.mp4 |
Description
Resolves: #1041
With this change:
Here is the demo:
electron_RMZzCLPpFU.mp4
And more screenshots:
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.