Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vallang build and target java 17 #226

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

DavyLandman
Copy link
Member

This superscedes #177

Copy link

github-actions bot commented Dec 14, 2023

Test Results

         96 files  ±0           96 suites  ±0   6m 42s ⏱️ +34s
242 283 tests ±0  242 282 ✔️ ±0  1 💤 ±0  0 ±0 
726 936 runs  ±0  726 933 ✔️ ±0  3 💤 ±0  0 ±0 

Results for commit 2c1fada. ± Comparison against base commit b422bb0.

♻️ This comment has been updated with latest results.

@jurgenvinju
Copy link
Member

I pushed changes to the CF setup for this. The problem was it was compiling against annotated JDK8 classes, and it needed some module configuration to give itself access to the Java compiler

@jurgenvinju
Copy link
Member

Ok it does not crash with errors during compile anymore, but null issues are not found either anymore. So still some work on getting CF back online.

@jurgenvinju
Copy link
Member

@DavyLandman Where does the Code QL action come from? Can't find it in the actions with grep.

@DavyLandman
Copy link
Member Author

DavyLandman commented Dec 14, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants