Special-case Date in deep-object-assign to ensure Dates work. #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomaash
approved these changes
Oct 3, 2023
|
🎉 This PR is included in version 5.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vis-util (used by vis-data, used in turn by vis-timeline) has some cloning/merging logic that works fine with primitives, Arrays, and Objects, but not so well with anything else. Ideally, it'd be nice if there was a generalizable fix for this that worked with arbitrary classes, but dates are common, at least in the vis-timeline case, and with the tests provided, are now guaranteed to work.
There's also an unrelated cross-env change that I needed to make the
BABEL_ENVthing in package.json work on Windows, but I suppose we can drop that if it's unwanted.This should cover visjs/vis-data#1014 and visjs/vis-timeline#1562 .