feat: pkg.pr.new #313
feat: pkg.pr.new #313
Conversation
| @@ -25,16 +25,19 @@ cli | |||
| .action(async (suites, options: CommandOptions) => { | |||
| const { root, vitePath, workspace } = await setupEnvironment() | |||
| const suitesToRun = getSuitesToRun(suites, root) | |||
| let viteMajor | |||
| let viteMajor = 5 | |||
There was a problem hiding this comment.
this is just a test, i wonder how we should get the viteMajor when we do not have the vite repo since we didn't set it up in commit mode.
| } else { | ||
| viteMajor = parseMajorVersion(options.release) | ||
| } | ||
| const runOptions: RunOptions = { | ||
| root, | ||
| viteCommit: options.commit, |
There was a problem hiding this comment.
viteCommit option for later in the test so we generate a tarball link from it.
| @@ -17,7 +17,7 @@ export async function test(options: RunOptions) { | |||
| ) | |||
| } | |||
| pkg.scripts.selftestscript = | |||
| "[ -d ../../vite/packages/vite/dist ] || (echo 'vite build failed' && exit 1)" | |||
| "pnpm vite -v || (echo 'vite build failed' && exit 1)" | |||
There was a problem hiding this comment.
This is a test too, since we do not have the repo anymore in commit mode, i just tried logging the vite version.
I think there should be a condition here.
|
The name I think the But this should probably stay as a draft until we figured out how it works with the planned comment triggers in vite repo. |
|
Yes, agreed! Let's handle things with the |
Whenever the commit is available, we avoid building vite and we use pkg.pr.new directly.
The idea is to get the commit sha from the vite repo when commenting in the workflow dispatch (
commitoption which is optional).