Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add playwright-ct tests #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mxschmitt
Copy link

I think that would help the ecosystem in order to prevent e.g. vitejs/vite#17478

'@sveltejs/vite-plugin-svelte-inspector': true,
},
build: 'build',
beforeTest: 'npx playwright install --with-deps',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need all here or can we limit it to chromium?

overrides: {
'@vitejs/plugin-react': true,
'@vitejs/plugin-vue': true,
'@vitejs/plugin-vue2': true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have a build config for that currently, it would have to be added to builds, similar to https://github.com/vitejs/vite-ecosystem-ci/blob/main/builds/vite-plugin-vue.ts

Is this something that adds more coverage over just plugin-vue, if not i'd prefer to not have this override and use a reduced ct-vite-ecosystem-ci test script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants