Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): ensure sass compiler initialized only once #18128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Sep 17, 2024

Description

The test I added doesn't fail on main since Vitest probably just exits regardless of hanging resource. However, it can be used to test it manually and this hangs on main:

pnpm -C playground/css build -c vite.config-sass-modern-compiler-build.js

Copy link

stackblitz bot commented Sep 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hi-ogawa hi-ogawa changed the title fix(css): instantiate sass compiler only once fix(css): ensure sass compiler initialized only once Sep 17, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review September 18, 2024 00:45
@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: css labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite build hangs with multiple scss input files when using 'modern-compiler'
3 participants