Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add vitepress-plugin-group-icons #18132

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

yuyinws
Copy link
Contributor

@yuyinws yuyinws commented Sep 18, 2024

Description

This PR add vitepress-plugin-group-icons to enhance the document's readability.

Preview

For code-groups

Add the icon on tab bar for code-groups

image

For code-block

Add title bar for code-block

image
image
image

Copy link

stackblitz bot commented Sep 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy
Copy link
Member

bluwy commented Sep 18, 2024

This looks really nice! I quite like this and I didn't notice something out of place. Would like to hear what others think about this.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me too!

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Sep 19, 2024
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I like this too.

@bluwy bluwy merged commit b529b6f into vitejs:main Sep 19, 2024
14 checks passed
@yuyinws yuyinws deleted the docs-group-icons branch September 19, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants