Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manifest): non entry CSS chunk src was wrong #18133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(manifest): non entry CSS chunk src was wrong #18133

wants to merge 1 commit into from
+13 −11

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 18, 2024 •
edited
Loading

Description

The document says:

For non entry chunks, the key is the base name of the generated file prefixed with _.

but this was not working for CSS chunks. This PR fixes that.

I used the same example project from #16620 to generate the manifest in the document.

@sapphi-red sapphi-red added the p2-edge-case Bug, but has workaround or limited in scope (priority) label Sep 18, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Sep 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @bluwy