feat: Adding possibility to get rid of prototypes from the output #6504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding possibility to get rid of printing prototype in diff output
Added a new configuration option `printBasicPrototype` to the diff section. This allows users to set the pretty-format option for the diff output, with a default value of `true`.
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
reviewed
Sep 18, 2024
Comment on lines
+2334
to
+2339
| #### diff.printBasicPrototype | ||
|
|
||
| - **Type**: `boolean` | ||
| - **Default**: `true` | ||
|
|
||
| Allows to set pretty-format option printBasicPrototype for diff output |
There was a problem hiding this comment.
Isn't it already default false on Vitest? https://vitest.dev/guide/snapshot.html#_2-printbasicprototype-is-default-to-false
There was a problem hiding this comment.
Aha, I just notice these two diff.printBasicPrototype and snapshotFormat.printBasicPrototype are different things. I think adding this option is okay to start with, but I wonder if we should have these two same as default.
Btw, can you add a test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
simplifies copying output to apply result in unit test
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.