feat: Add UidBone #1131
feat: Add UidBone #1131
Conversation
|
Some Points for the viur meeting
|
ArneGudermann
removed
the
viur-meeting
Co-authored-by: Sven Eberth <[email protected]>
|
mhh i have found an interesting bug. So if I call up a skel view in which this bone exists but it has not yet been written, a uid is automatically assigned but not written in the skel. This leads to the number not being used. |
ArneGudermann
added
viur-meeting
Fixed by: 041da3b |
| pattern = pattern() | ||
| self.pattern = str(pattern) | ||
| if self.pattern.count("*") != 1: | ||
| raise ValueError("Only one Wildcard (*) is allowed in the pattern") |
There was a problem hiding this comment.
| raise ValueError("Only one Wildcard (*) is allowed in the pattern") | |
| raise ValueError("Only one wildcard (*) is allowed and required in the pattern") |
| if len(self.fillchar) != 1: | ||
| raise ValueError("Only one char is allowed as fillchar") |
There was a problem hiding this comment.
The ValueError is also raised on an empty fillchar, which is the default. Is this wanted?
| if not self.readOnly: | ||
| self.readOnly = True |
There was a problem hiding this comment.
Can you solve this differently? Default readOnly flag shall be True, and changing it should raise a ValueError. The user should know that this bone can't be set readOnly=False.
| """ | ||
| Initializes a new UidBone. | ||
|
|
||
|
|
Proposal for #1117