Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

Directly reference jQuery and not $ #267

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jordanbyron
Copy link

This PR makes this gem's jQuery dependency explicit by adding it to the README plus wraps all JS files which reference jQuery in a self-invoking anonymous function. This is handy if jQuery is in noconflict mode and being used alongside prototype.

@@ -19,6 +19,7 @@

* ImageMagick or GraphicsMagick (for MiniMagick);
* [Bootstrap 3](http://getbootstrap.com/) fully installed in your app.
* jQuery
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Bootstrap 3 fully installed in your app" already implies that jQuery is required.


this.$el = $el;
this.unsavedChanges = false;
this.locale = $el.data("bootsy-locale") || $("html").attr("lang");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why single quotes?

@@ -10,113 +10,119 @@
<a class="btn">Browse</a>

*/
$(function() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an external dependency, please do not modify it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants