Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/show important directive #12942

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ajomuch92
Copy link

Adding support for important modifier on v-show directive

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

The explanation to include this feature is when you have a component (from an external library or own component) and this component has a display flex (or other display property on CSS), the v-show directive doesn't work showing the content you are trying to hide/show. You can make a workaround, like switching the class with the condition used into the directive, but it could be easier for developers only add this modifier

@posva
Copy link
Member

posva commented Jan 24, 2023

Did you see this idea was already rejected at #3761 ?

@ajomuch92
Copy link
Author

@posva Yes, I read that issue, but I think this is relevant, because I have met with this problem many times, and other devs faced this too.

I think it's not big deal to implement it, another library did it

@ajomuch92
Copy link
Author

@posva Also, if we implement a custom directive to display none important, this new one doesn't trigger the transition classes (if it's wrapped by a transition component), keep in mind

@ajomuch92
Copy link
Author

@posva any news from this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants