Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): no props typings in js files #13109

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ilanaya
Copy link

@Ilanaya Ilanaya commented Nov 1, 2023

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This PR intended to fix an annoying problem that caused no type support for props in js files. As it said it ts documentation unspecified types defaults to any which caused the whole props object to become any.

Explicitly specifying the type unknown in generic should fully fix this problem.

References:
Similar PR addressing the same issue but with a bit harder solution

Known Vue language tools issues which are closed as upstream because of this bug.
vuejs/language-tools#2347
vuejs/language-tools#1537

computed: {
test() {
// @ts-expect-error Invalid typecast if `this.a` is not any
;/** @type import('../utils').IsAny<typeof this.a> */ (this.a)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this.a is any this conversion wouldn't result in an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant