Rework WasiFs to use a "holey" FdList instead of hashmap + seed + fre… #4997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
approved these changes
Aug 22, 2024
Open
|
Waiting on @theduke to provide context on one test on Edge that failed on this PR, so we can move forward. Edit: context provided in Linear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed_fds
This PR implements
Vec<Option<Fd>>-based FD management.Note: I haven't extensively tested the code yet, so the PR is in draft status. I'm creating it so we can all review and discuss the implementation.