Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive sponsor ad #7228

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JamesSwinton
Copy link
Contributor

I have updated the AG Grid sponsor section so that it appears on small & mobile devices.

Copy link

vercel bot commented Apr 11, 2024

@JamesSwinton is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

@alexander-akait
Copy link
Member

@JamesSwinton Can you add screenshots before/after, thank you

@JamesSwinton
Copy link
Contributor Author

JamesSwinton commented Apr 11, 2024

Hey @alexander-akait, sure, no problem:

Before:
Before

After:
After

@alexander-akait
Copy link
Member

Can you rebase?

@JamesSwinton
Copy link
Contributor Author

Should be ready to merge now, thanks

@chenxsan
Copy link
Member

chenxsan commented May 27, 2024

Not sure we want to show ads on top of small screens, it would be terrible UX IMO.

@snitin315
Copy link
Member

I agree, showing add on top would shift the content below leading to a degraded UX. Maybe we can do something similar to ESLint, it moves the ad to the footer on small screens.

Screenshot 2024-06-04 at 6 05 52 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants