Avoid stack overflow

refs: #32
wez · Jul 13, 2021 · d72ccf0 · d72ccf0
1 parent 020176f
commit d72ccf0
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,3 +23,16 @@ jobs:
       run: cmake .
     - name: build
       run: cmake --build . --config Release
+
+  asan:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+    steps:
+    - uses: actions/checkout@v2
+    - name: configure
+      run: cmake -DASAN=on -DCMAKE_BUILD_TYPE=Debug .
+    - name: build
+      run: cmake --build .
+    - name: test
+      run: tests/test.sh
diff --git a/src/extracts.cpp b/src/extracts.cpp
@@ -1588,7 +1588,7 @@ void APar_Print_TrackDetails(TrackInfo *track_info) {
 }
 
 void APar_ExtractDetails(FILE *isofile, uint8_t optional_output) {
-  char uint32_buffer[5];
+  char uint32_buffer[8];
   Trackage track = {0};
 
   AtomicInfo *mvhdAtom = APar_FindAtom("moov.mvhd", false, VERSIONED_ATOM, 0);

diff --git a/tests/issue-32.mp4 b/tests/issue-32.mp4
diff --git a/tests/test.sh b/tests/test.sh
@@ -0,0 +1,3 @@
+#!/bin/bash
+set -xe
+./AtomicParsley ./tests/issue-32.mp4 -T 1 -t +