Complete draft spec for customizable <select>
#10548
Draft
+831
−355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josepharhar
force-pushed
the
selectcomplete
branch
from
8be5f47
to
0bee650
Compare
josepharhar
force-pushed
the
selectcomplete
branch
2 times, most recently
from
4691e13
to
bef9083
Compare
scottaohara
reviewed
Aug 8, 2024
josepharhar
force-pushed
the
selectcomplete
branch
from
34be830
to
fed19dc
Compare
scottaohara
reviewed
Aug 14, 2024
|
FYI: I am likely going to remove the author-provided datalist and fallback UA button in this PR soon based on recent discussions, which will likely reduce the number of changes and complexity. |
This was referenced Aug 20, 2024
josepharhar
force-pushed
the
selectcomplete
branch
2 times, most recently
from
d341596
to
6dab95d
Compare
This PR updated the content model for the <select>, <option>, and <optgroup> elements in support of customizable <select>. Fixes whatwg#10317
josepharhar
force-pushed
the
selectcomplete
branch
from
6dab95d
to
57e00bf
Compare
mtrootyy
reviewed
Aug 30, 2024
source
Outdated
| @@ -53203,7 +53306,8 @@ interface <dfn interface>HTMLButtonElement</dfn> : <span>HTMLElement</span> { | |||
| <dt><span data-x="concept-element-contexts">Contexts in which this element can be used</span>:</dt> | |||
| <dd>Where <span>phrasing content</span> is expected.</dd> | |||
| <dt><span data-x="concept-element-content-model">Content model</span>:</dt> | |||
| <dd>Zero or more <code>option</code>, <code>optgroup</code>, <code>hr</code>, and <span data-x="script-supporting elements">script-supporting</span> elements.</dd> | |||
| <dd>Zero or more <span>select element inner content elements</span>.</dd> | |||
| <dd>Zero or one child <code>button</code>.</dd> | |||
There was a problem hiding this comment.
According to this content model, the example of following is conforming.
But is that OK?
One or more "option" element should be required as a descendant of "select" element.
Example
<select>
<div>unselectable-text-1</div>
<span>unselectable-text-2</span>
<noscript>unselectable-text-3</noscript>
<hr>
<img src="unselectable-image-1.jpg">
<svg><text>unselectable-image-2</text></svg>
</select>
mtrootyy
reviewed
Aug 30, 2024
source
Outdated
| <option>Cat</option> | ||
| <option>Dog</option> | ||
| </datalist> | ||
| </select></code></pre> |
There was a problem hiding this comment.
The "datalist" element should be added to "Select element inner content elements" category.
mtrootyy
reviewed
Aug 31, 2024
source
Outdated
| @@ -53203,7 +53306,8 @@ interface <dfn interface>HTMLButtonElement</dfn> : <span>HTMLElement</span> { | |||
| <dt><span data-x="concept-element-contexts">Contexts in which this element can be used</span>:</dt> | |||
| <dd>Where <span>phrasing content</span> is expected.</dd> | |||
| <dt><span data-x="concept-element-content-model">Content model</span>:</dt> | |||
| <dd>Zero or more <code>option</code>, <code>optgroup</code>, <code>hr</code>, and <span data-x="script-supporting elements">script-supporting</span> elements.</dd> | |||
| <dd>Zero or more <span>select element inner content elements</span>.</dd> | |||
| <dd>Zero or one child <code>button</code>.</dd> | |||
| <dt><span data-x="concept-element-attributes">Content attributes</span>:</dt> | |||
There was a problem hiding this comment.
The "selectedoptionelement" attribute should be added.
mtrootyy
reviewed
Aug 31, 2024
| @@ -55816,6 +56196,115 @@ interface <dfn interface>HTMLLegendElement</dfn> : <span>HTMLElement</span> { | |||
|
|
|||
| </div> | |||
|
|
|||
| <h4>The <dfn element><code>selectedoption</code></dfn> element</h4> | |||
|
|
|||
There was a problem hiding this comment.
Is there no begining block(list of "Categories:", "Contexts in which this element can be used:", "Content model:", "Tag omission in text/html:", "Content attributes:", "Accessibility considerations:" & "DOM interface:") in section of the selectedoption element?
mtrootyy
reviewed
Aug 31, 2024
source
Outdated
|
|
||
| <li><code>noscript</code> elements.</li> | ||
|
|
||
| <li><code>div</code> elements.</li> |
There was a problem hiding this comment.
The following sentences should be added to the bigining block of section of the div element.
Categories:
......
+Select element inner content elements.
Contexts in which this element can be used:
......
+As a child of a select element.
+As a child of a optgroup element.
+As a child of a option element.
If the div element may have option element & optgroup element as child, that fact should be added to "Content model:".
Other element of "Select element inner content elements" should be also.
josepharhar
force-pushed
the
selectcomplete
branch
2 times, most recently
from
939fe27
to
04e9fcd
Compare
This patch makes the parser allow additional tags in <select> besides <option>, <optgroup>, and <hr>, mostly by removing the "in select" and "in select in table" parser modes. In order to replicate the behavior where opening a <select> tag within another open <select> tag inserts a </select> close tag, a traversal through the stack of open elements was added which I borrowed from the <button> part of the parser. This will need test changes to be implemented in html5lib. Fixes whatwg#10310
josepharhar
force-pushed
the
selectcomplete
branch
from
04e9fcd
to
46cddc3
Compare
josepharhar
force-pushed
the
selectcomplete
branch
from
46cddc3
to
50bf192
Compare
josepharhar
force-pushed
the
selectcomplete
branch
from
50bf192
to
12edc88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete draft spec for customizable
<select>as proposed here<select>element #9799I don't intend to merge this PR, but instead to break off pieces of it and make PRs for those. However, feedback is greatly appreciated.
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Sep 12, 2024, 10:07 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.