Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Add proper serialization of URL properties #224

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

rubycon
Copy link
Contributor

@rubycon rubycon commented Mar 16, 2024

This PR fix missing serialization steps of internal port and host properties in the spec. The URL parser return port as an integer and host as either a hostname string, an integer (IPv4 address) or an array of integers (IPv6 address). For further processing by the URLPattern code these properties need to be properly converted to string.

The issue was discussed here: #202 (comment)


Preview | Diff

@jeremyroman
Copy link
Collaborator

Thanks for the pull request. Only a couple things before I can merge it.

  1. Please amend the commit message according to meta/COMMITTING.md. In particular, the first line should probably be marked as "Editorial" (which lets us avoid many of the usual checks) and be written in the imperative. I can do this when merging it need be.
  2. You need to be covered by an appropriate participation agreement which applies to at least the URL workstream.

@rubycon rubycon changed the title Proper serialization of URL properties Editorial: Proper serialization of URL properties Mar 21, 2024
@rubycon rubycon changed the title Editorial: Proper serialization of URL properties Editorial: Add proper serialization of URL properties Mar 21, 2024
@rubycon
Copy link
Contributor Author

rubycon commented Mar 21, 2024

@jeremyroman I updated my PR title and submitted a participant agreement, waiting for its validation.

@annevk annevk requested a review from jeremyroman April 17, 2024 14:12
@jeremyroman
Copy link
Collaborator

The WHATWG page says:

@rubycon has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end!

@annevk do you know what need to be done for it to be "verified"? I'm not super familiar with how individual participation works.

@domenic
Copy link
Member

domenic commented Apr 19, 2024

@jeremyroman jeremyroman merged commit d13ebea into whatwg:main Apr 19, 2024
2 checks passed
@jeremyroman
Copy link
Collaborator

Gotcha; done. (Was that linked from the check status page? If so, I missed it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants