Issue 174 rev3 (team 4) #225

agiz · 2012-06-07T21:44:10Z

API for displaying stores around nodes from odpiralnicasi.com
Provided short demonstration how to integrate api information into template.

Conflicts: piplmesh/frontend/templates/base.html

agiz · 2012-06-07T21:47:18Z

Changed zoom properties on map for purposes of this api (must be changed back to 15 or 16).
Does square brackets notation I used for arrays needs to be changed for dotted one?
This pull request is up to date (12e518f)
This pull request addresses issue Add panel with open venues from Odpiralni Casi #174.

mitar · 2012-06-07T22:27:55Z

Please update from main repository. You have panels API available. Check it out. ;-)

Conflicts: piplmesh/frontend/templates/home.html

agiz · 2012-06-08T09:04:52Z

Please support laziness and tell how to enable a panel. Can it be determined what panels should load first?

mitar · 2012-06-08T09:12:49Z

Currently all panels under piplmesh.panels are added automatically (if you register them into panels_pool, of course). For the rest, there is a pending pull request #189. So ordering them in display and so on.

API also supports defining dependencies between panels. But as currently all panels are always displayed, this is not a problem.

Also order of loading on the page is not important and should not be important if you do it correctly. So, first, you do everything through jquery.ready in every panel.

Then, I suggest you define custom event which you will trigger when map is ready. And other panels can then in their jquery.ready subscribe to that event. Of course, if map is already ready when they subscribe to the event, they should be immediately run, not just waiting for the event which will never come anymore. So it should behave like jquery.ready does, only for maps. I am not really sure if jQuery supports something like this already, but it maybe does. Check it out.

So, you should define your own JavaScript API in the map in the way that other panels can use the map, without being afraid of the loading order.

agiz · 2012-06-08T09:16:01Z

By

(if you register them into panels_pool, of course)

do you mean create them under panels directory? Because I have done that. Can underscore in panel name be an issue?

mitar · 2012-06-08T09:17:17Z

Can you show me the code?

No, underscore should not be a problem. But name is automatically derived from the class name otherwise, and it is probably best to just leave it as it is?

mitar · 2012-06-08T09:17:49Z

You have restarted runserver? Really restart, not just leave to its autoreload.

agiz · 2012-06-08T09:20:19Z

Grrr. This is the stupidest github part. If you rename files it stops tracking them or what? I do not even have option to add them manually.

mitar · 2012-06-08T09:21:52Z

Github? Or git? You should be renaming always with git mv.

agiz · 2012-06-08T09:23:57Z

I have known this issue before, I was just never affected by it. Anyway, please check this pull request now, it seems to represent my structure correctly.

mitar · 2012-06-08T09:26:39Z

And where is Python code which goes with the panel? There is where you register the panel into the pool.

mitar · 2012-06-08T09:27:41Z

And please name it odpiralnicasi. ;-)

mitar · 2012-06-08T09:27:49Z

And OdpiralniCasiPanel.

agiz · 2012-06-08T09:30:43Z

Aaaa.So that is what is mean by registering into the pool. Nonetheless I have added that and panel still does not load.

mitar · 2012-06-08T09:30:48Z

Or even name it openhours. That is their English name:

http://odpiralnicasi.com/en/

mitar · 2012-06-08T09:31:39Z

Please check everything precisely. You do have __init__.py file?

agiz · 2012-06-08T09:32:57Z

Are panels connected by context header? I mean does Map panel name connect with map directory name?

agiz · 2012-06-08T09:33:40Z

I did have __init__.py before just forgot to add it, but panel.py was indeed missing.

mitar · 2012-08-14T06:25:53Z

I have documented JavaScript code style here:

#199 (comment)

mitar · 2012-08-25T20:55:31Z

TODO.

mitar · 2012-08-26T23:33:01Z

Please update from main repository.

Conflicts: piplmesh/frontend/static/piplmesh/jquery/css/jquery-ui.css piplmesh/frontend/static/piplmesh/jquery/jquery-ui.js piplmesh/frontend/templates/base.html piplmesh/panels/onlineusers/templates/panel/onlineusers/panel.html

agiz · 2012-09-12T10:21:41Z

BUMP! Updated from main repository.

mitar · 2012-09-12T10:25:55Z

Vuii, you are alive!!! :-)

agiz · 2012-09-12T10:34:40Z

Hehe, yes hardly :). I wish I was relaxing all this time as it might be seen from lack of my activity here. Unfortunately that was not the case :(.

agiz · 2012-09-24T16:58:49Z

Umm hi again. Have I overlooked something that needs to be done here?

mitar · 2012-09-27T06:07:49Z

No time on my side. There are others which need to pass the class.

BTW, please update from main repository, again. Sorry!

mitar · 2012-09-27T06:08:12Z

(We got now also big map functionality. The idea is to provide layers there! And that people can move around!)

Conflicts: piplmesh/panels/map/static/piplmesh/panel/map/panel.js piplmesh/panels/map/templates/panel/map/panel.html

agiz · 2012-09-27T13:46:57Z

No problem Mitar. I understand how priorities work. Also updated. I have not checked big map yet, I am on a rough schedule myself.

mitar · 2012-09-28T10:03:27Z

piplmesh/panels/openhours/static/piplmesh/panel/openhours/panel.js

+        self.today = self.is_open ? gettext("open") : gettext("closed");
+        self.___location = new google.maps.LatLng(self.lat, self.lng);
+        self.image = 'https://www.google.com/intl/en_us/mapfiles/ms/micons/yellow-dot.png';
+        if ('is_open' in self && self.is_open == true) {


self.is_open == true? Why not just self.is_open?

…d numbers with string literals.

agiz · 2012-10-11T17:09:42Z

Fixed some minor mistakes, somewhat clueless how to combat others.

mitar · 2012-10-24T08:21:08Z

piplmesh/panels/openhours/static/piplmesh/panel/openhours/panel.js

+    });
+}
+
+map_loaded.done(function () {


Where is map_loaded defined?

mitar · 2012-10-29T13:48:51Z

So about which things you are clueless? I can try to help.

agiz added 7 commits June 7, 2012 23:30

Added map to external variable.

85e40b7

Added odprti casi api.

19a60ce

Added odprti casi template.

548bc61

Added this, odprti casi template.

1aae025

Odprti casi api.

23960d9

Merge remote-tracking branch 'origin/master' into issue-174_rev3

ac81860

Conflicts: piplmesh/frontend/templates/base.html

Merge changes.

ad59580

agiz added 2 commits June 8, 2012 10:09

Merge remote-tracking branch 'origin/master' into issue-174_rev3

8fc5fef

Conflicts: piplmesh/frontend/templates/home.html

Merge.

b5d6115

Moved odpiralni_casi to panels.

e913e81

Manually added odpiralni_casi panel.

b96da7d

Registered odpiralni_casi into panels pool.

b26030f

agiz added 3 commits August 27, 2012 12:06

Combined enclosing brackets.

e73d966

Added jQuery style and image files.

75005b5

Merge branch 'master' into issue-174_rev3

bc22dd2

Conflicts: piplmesh/frontend/static/piplmesh/jquery/css/jquery-ui.css piplmesh/frontend/static/piplmesh/jquery/jquery-ui.js piplmesh/frontend/templates/base.html piplmesh/panels/onlineusers/templates/panel/onlineusers/panel.html

Merge branch 'master' into issue-174_rev3

209a394

Conflicts: piplmesh/panels/map/static/piplmesh/panel/map/panel.js piplmesh/panels/map/templates/panel/map/panel.html

mitar reviewed Sep 28, 2012
View reviewed changes

Code modifications in accordance with coding style. Replaced hardcode…

264fa4c

…d numbers with string literals.

mitar reviewed Oct 24, 2012
View reviewed changes

piplmesh/panels/openhours/static/piplmesh/panel/openhours/panel.js

});

}

map_loaded.done(function () {

Copy link

Member

mitar Oct 24, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is map_loaded defined?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 174 rev3 (team 4) #225

Issue 174 rev3 (team 4) #225

agiz commented Jun 7, 2012

agiz commented Jun 7, 2012

mitar commented Jun 7, 2012

agiz commented Jun 8, 2012

mitar commented Jun 8, 2012

agiz commented Jun 8, 2012

mitar commented Jun 8, 2012

mitar commented Jun 8, 2012

agiz commented Jun 8, 2012

mitar commented Jun 8, 2012

agiz commented Jun 8, 2012

mitar commented Jun 8, 2012

mitar commented Jun 8, 2012

mitar commented Jun 8, 2012

agiz commented Jun 8, 2012

mitar commented Jun 8, 2012

mitar commented Jun 8, 2012

agiz commented Jun 8, 2012

agiz commented Jun 8, 2012

mitar commented Aug 14, 2012

mitar commented Aug 25, 2012

mitar commented Aug 26, 2012

agiz commented Sep 12, 2012

mitar commented Sep 12, 2012

agiz commented Sep 12, 2012

agiz commented Sep 24, 2012

mitar commented Sep 27, 2012

mitar commented Sep 27, 2012

agiz commented Sep 27, 2012

mitar Sep 28, 2012

agiz commented Oct 11, 2012

mitar Oct 24, 2012

mitar commented Oct 29, 2012

Issue 174 rev3 (team 4) #225

Are you sure you want to change the base?

Issue 174 rev3 (team 4) #225

Conversation

agiz commented Jun 7, 2012

agiz commented Jun 7, 2012

mitar commented Jun 7, 2012

agiz commented Jun 8, 2012

mitar commented Jun 8, 2012

agiz commented Jun 8, 2012

mitar commented Jun 8, 2012

mitar commented Jun 8, 2012

agiz commented Jun 8, 2012

mitar commented Jun 8, 2012

agiz commented Jun 8, 2012

mitar commented Jun 8, 2012

mitar commented Jun 8, 2012

mitar commented Jun 8, 2012

agiz commented Jun 8, 2012

mitar commented Jun 8, 2012

mitar commented Jun 8, 2012

agiz commented Jun 8, 2012

agiz commented Jun 8, 2012

mitar commented Aug 14, 2012

mitar commented Aug 25, 2012

mitar commented Aug 26, 2012

agiz commented Sep 12, 2012

mitar commented Sep 12, 2012

agiz commented Sep 12, 2012

agiz commented Sep 24, 2012

mitar commented Sep 27, 2012

mitar commented Sep 27, 2012

agiz commented Sep 27, 2012

mitar Sep 28, 2012

Choose a reason for hiding this comment

agiz commented Oct 11, 2012

mitar Oct 24, 2012

Choose a reason for hiding this comment

mitar commented Oct 29, 2012