Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break apko,melange,wolfictl images, point to sdk image #116

Merged
merged 5 commits into from
May 12, 2024

Conversation

imjasonh
Copy link
Contributor

@imjasonh imjasonh commented May 11, 2024

These single-tool images don't serve much of a purpose when the sdk image has all those tools and more. We've tried to converge on the sdk image, but we don't know what might still be using these.

This builds the image so that they'll fail when invoked, and tell folks clearly that they should use ghcr.io/wolfi-dev/sdk instead.

$ cd images/apko
$ terraform init && terraform apply -auto-approve
$ docker run --rm ttl.sh/jason:latest@sha256:182914446ec4100a293853f6d99324755a454c1dd0b8e38c87251a608e79765c
PLEASE USE ghcr.io/wolfi-dev/sdk INSTEAD
$ echo $?
1

@imjasonh
Copy link
Contributor Author

imjasonh commented May 11, 2024

Looks like this will need #115 to be able to pass presubmit.

@imjasonh imjasonh enabled auto-merge May 11, 2024 14:25
@imjasonh
Copy link
Contributor Author

imjasonh commented May 11, 2024

This will also require tweaks to the required CI checks, since we're not melange-building apko or melange anymore.

edit: done

@imjasonh imjasonh disabled auto-merge May 11, 2024 14:48
@imjasonh imjasonh enabled auto-merge May 11, 2024 14:48
@imjasonh imjasonh disabled auto-merge May 12, 2024 01:05
@imjasonh imjasonh enabled auto-merge May 12, 2024 01:05
@imjasonh imjasonh merged commit 55d5f6b into wolfi-dev:main May 12, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants