Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title, description and gatewayId to the express payment method #2566

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

alexflorisca
Copy link
Member

This PR ads title, description and gatewayId props to express payment methods to be displayed in the editor. These are used to display the available express payment methods to a merchant, once they click on the express checkout block.

This is parallel work with woocommerce/woocommerce#50791 and the feature/express-payment-improvements branch should be used to test. However this should also work with the current release of WC, and can be safely merged and released before the work in Core is released.

If these props are no provided, the name is used instead and the list will look like this:

Screenshot 2024-09-04 at 16 31 45

After this PR, the list should look like this:

Screenshot 2024-09-04 at 16 29 37

The link for the PayPal payment method should take you to the PayPal settings.

Testing instructions

  1. Visit the checkout page in the editor
  2. Click on the express payment block
  3. See on the right hand sidebar that the list of Express Payment methods shows, and that the PayPal method has a title, description and the link goes to the PayPal settings page.
  4. Smoke test with current WC version and make sure the express method still works as expected.

Changelog Entry

Add additional title, description and gatewayId props to the express payment method for displaying in the editor

@alexflorisca alexflorisca changed the title Update/add title description and gateway Add title, description and gatewayId to the express payment method Sep 4, 2024
@alexflorisca alexflorisca self-assigned this Sep 4, 2024
@alexflorisca alexflorisca added enhancement New feature or request woo-compatibility Issues relating to official WooCommerce plugins blocks labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocks enhancement New feature or request woo-compatibility Issues relating to official WooCommerce plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant