WIP: Dzejkop/bump semaphore #770
Open
+1,122
−372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKitsune
approved these changes
Sep 18, 2024
Comment on lines
+16
to
+45
| struct Args { | ||
| #[clap(subcommand)] | ||
| subcommand: Command, | ||
|
|
||
| #[clap( | ||
| short, | ||
| long, | ||
| env, | ||
| default_value = "https://signup-orb-ethereum.crypto.worldcoin.dev" | ||
| )] | ||
| sequencer_url: String, | ||
|
|
||
| #[clap(long, env)] | ||
| basic_auth_username: Option<String>, | ||
|
|
||
| #[clap(long, env)] | ||
| basic_auth_password: Option<String>, | ||
|
|
||
| /// The path to the file that will be used to store the identity | ||
| #[clap(long, env)] | ||
| identity_file: Option<PathBuf>, | ||
|
|
||
| /// The path to the file that will be used to store the inclusion proof | ||
| #[clap(long, env)] | ||
| inclusion_proof_file: Option<PathBuf>, | ||
|
|
||
| /// The path to the file that will be used to store the semaphore proof | ||
| #[clap(long, env)] | ||
| semaphore_proof_file: Option<PathBuf>, | ||
| } |
There was a problem hiding this comment.
It looks specific args are only used for certain commands. Consider using a similar approach to forge where each command has it's own set of args. The cli tool is pretty simple so this is not necessary, just a thought for consideration.
There was a problem hiding this comment.
A lot of them are unique, but many are shared between commands. And putting them in the base command means that running ./tool --help displays helpful information, if I put them in each subcommand then a user needs to run ./tool --help followed by ./tool cmd --help for relevant information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps semaphore to newest with oxide branch merged.
Also adds a small CLI tool to do local proof generation and verification