Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #12 #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes #12 #14

wants to merge 2 commits into from

Conversation

uniqby
Copy link

@uniqby uniqby commented Mar 15, 2013

No description provided.

Alexander Sazanovich added 2 commits March 15, 2013 10:18
…_1', 'field_2') )

fixes #12 Crashes when owner model has complex PK ( ex.:
array('field_1', 'field_2') )
@@ -103,6 +108,9 @@ public function attach($owner) {
$this->cache = new CDummyCache;
}

if (null === $this->ownerPk)
$this->ownerPk = $this->ownerPk;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for?
You are introducing a new property but never setting it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants