taggable: Accept only the first case-variant of a tag #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Mysql searches case insensitive and different case-variants of the same tag are usually not used, we need to make sure only one variant of a tag is available.
this depends on the table collation so it is not always true. |
|
Good point cebe, nonetheless, it would be preferable to be configurable in case it does search case insensitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Mysql searches case insensitive, duplicate case-variants lead to duplicate primary key combination. Usually, different case-variants of the same tag are usually not used. We need to make sure only one variant of a tag is available.